[SecurityBundle] Make firewalls event dispatcher traceable on debug mode #49021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you illustrate what this brings to userland with e.g. a screenshot? |
|
@chalasr done! |
688e0bf to
9c80f15
Compare
chalasr
previously approved these changes
Jan 26, 2023
|
Can you add some test? Also can you double check that there is no existing compiler pass that could be patched instead of adding a new one? |
Did not find anything related, which kind of surprised me because what I’m doing here feels like it could be generic 🤔 |
chalasr
approved these changes
Jan 26, 2023
|
Damn I broke |
...le/SecurityBundle/DependencyInjection/Compiler/MakeFirewallsEventDispatcherTraceablePass.php
Outdated
Show resolved
Hide resolved
...le/SecurityBundle/DependencyInjection/Compiler/MakeFirewallsEventDispatcherTraceablePass.php
Outdated
Show resolved
Hide resolved
754690d to
4817130
Compare
|
Looks like #49021 (comment) was the cause of the failing test, which is weird? How could it register |
nicolas-grekas
approved these changes
Jan 26, 2023
c1d91ea to
c5407ce
Compare
|
Thank you @MatTheCat. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 19, 2023
…(MatTheCat) This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel] Collect data from every event dispatcher | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up of #49021: instead of only passing the main event dispatcher to the `EventDataCollector`, we pass them all (thanks to the `event_dispatcher.dispatcher` tag).  (The heading is now “Dispatched Events”.) Check “Hide whitespace” when reviewing. Commits ------- 7a77b3a [HttpKernel] Collect data from every event dispatcher
Merged
fabpot
added a commit
that referenced
this pull request
Mar 17, 2024
…firewall event dispatcher (danielburger1337) This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [SecurityBundle] Use "event" monolog channel in traceable firewall event dispatcher | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | n/a | License | MIT I think since #49021 was merged, security events in debug mode are logged inside the "app" (default) channel. This is very annoying in an API use case as every request generates about 10 _useless_ log entries. This PR changes the monolog channel of the traceable event dispatcher to `event` and also tags it with `kernel.reset`. This matches the behavior of `debug.event_dispatcher`. Commits ------- 3995c71 [SecurityBundle] Use "event" monolog channel in traceable firewall event dispatcher
symfony-splitter
pushed a commit
to symfony/security-bundle
that referenced
this pull request
Mar 17, 2024
…firewall event dispatcher (danielburger1337) This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [SecurityBundle] Use "event" monolog channel in traceable firewall event dispatcher | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | n/a | License | MIT I think since symfony/symfony#49021 was merged, security events in debug mode are logged inside the "app" (default) channel. This is very annoying in an API use case as every request generates about 10 _useless_ log entries. This PR changes the monolog channel of the traceable event dispatcher to `event` and also tags it with `kernel.reset`. This matches the behavior of `debug.event_dispatcher`. Commits ------- 3995c71b61 [SecurityBundle] Use "event" monolog channel in traceable firewall event dispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decorates firewalls event dispatcher with
TraceableEventDispatcheron debug mode. This will display security events and listeners in the profiler’stimepanel.Before
After
They still won’t appear in the
eventspanel (because theEventDataCollectoris only injecteddebug.event_dispatcher) but I think it will be best handled in a separate PR.