[ExpressionLanguage] Deprecate loose comparisons when using the "in" operator #49064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jan 22, 2023
wouterj
approved these changes
Jan 22, 2023
9260e92 to
31c6681
Compare
Good call, I added your suggestions in the deprecation message directly |
31c6681 to
032ee26
Compare
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jul 4, 2023
…xandre-daubois) This PR was merged into the 7.0 branch. Discussion ---------- [ExpressionLanguage] Remove deprecated code paths | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | symfony/symfony-docs#18486 - The `in` and `not in` operators now use strict comparison #49064 Commits ------- 7050bc8 [ExpressionLanguage] Remove deprecated code paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twig already uses strict comparisons for its "in" operator. Using loose comparisons can be a foot-gun, since eg
"foo"is currently "in"["bar", true]. I propose to trigger a deprecation in v6.3 and make the comparison strict in v7.0.The deprecation is not really actionable but I don't have a better idea that doesn't involve adding a new operator, and I can't find something that'd be better than "in".
I propose to merge as is and see later on with feedback from the community if we need more.