Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Utilize shivammathur/setup-php to install Relay extension #49125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

Utilize shivammathur/setup-php to install Relay extension #49125

merged 1 commit into from
Jan 27, 2023

Conversation

ostrolucky
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Follow-up to #48930
License MIT
Doc PR

This is possible since https://github.com/shivammathur/setup-php/releases/tag/2.24.0. A bit unfortunate timing since they tagged it one day after we merged relay, but no biggie.

@carsonbot carsonbot added this to the 6.3 milestone Jan 27, 2023
@fabpot
Copy link
Member

fabpot commented Jan 27, 2023

Thank you @ostrolucky.

@fabpot fabpot merged commit f06554b into symfony:6.3 Jan 27, 2023
@ostrolucky
Copy link
Contributor Author

Sorry, I should have made this draft PR. Actually I found this doesn't work, looks like setup-php doesn't recognize dev version

image

CI passes because tests are skipped. @till can you release new tag of Relay so that Symfony CI doesn't have to rely on dev version? Then I'll create a new PR here which fixes it.

@till
Copy link
Contributor

till commented Jan 27, 2023

I can't answer that. 🤪

@ostrolucky
Copy link
Contributor Author

Ah sorry, I meant to ping @tillkruss

@stof
Copy link
Member

stof commented Jan 27, 2023

@ostrolucky do we actually need to use the dev version of the extension or could the CI run agaist the latest release of the extension (as done for other extensions) ?

@ostrolucky
Copy link
Contributor Author

Yeah we need dev version at the moment, here is what happens with latest stable one https://github.com/symfony/symfony/actions/runs/4022602419/jobs/6912513765

@tillkruss
Copy link

@ostrolucky I can tag a release this morning.

@tillkruss
Copy link

v0.6.0 is out: https://github.com/cachewerk/relay/releases/tag/v0.6.0

@ostrolucky ostrolucky mentioned this pull request Jan 27, 2023
Merged
derrabus added a commit that referenced this pull request Jan 28, 2023
@derrabus
minor #49136 CI: Use stable version of relay (ostrolucky)
b497938 
This PR was merged into the 6.3 branch.

Discussion
----------

CI: Use stable version of relay

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | #49125 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

a4a1909 CI: Use stable version of relay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ostrolucky @fabpot @till @stof @tillkruss @carsonbot