Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle][HttpKernel] Display warmers duration on debug verbosity for cache:clear command #49139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

[FrameworkBundle][HttpKernel] Display warmers duration on debug verbosity for cache:clear command #49139

merged 1 commit into from
Feb 22, 2023

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jan 27, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #48994
License MIT
Doc PR Todo

From the idea of the issue it fixes. When dealing with huge code base, the cache/warmup process can be a bit long. It would be convenient for developers to understand where it does take time during the process. Here is the result of cache:clear ran with debug verbosity now:

image

@carsonbot carsonbot added this to the 6.3 milestone Jan 27, 2023
@alexandre-daubois alexandre-daubois force-pushed the feat-warmer-finished-event branch 3 times, most recently from 8e7b06b to f6de7bb Compare January 27, 2023 21:31
@alexandre-daubois alexandre-daubois force-pushed the feat-warmer-finished-event branch from f6de7bb to 07b72de Compare February 20, 2023 20:10
@alexandre-daubois alexandre-daubois force-pushed the feat-warmer-finished-event branch from 07b72de to 32213d8 Compare February 21, 2023 19:55
@alexandre-daubois
Copy link
Member Author

That's all updated! Thanks for suggesting this more pragmatic way 🙏

@alexandre-daubois alexandre-daubois force-pushed the feat-warmer-finished-event branch 3 times, most recently from ba9253e to e23e254 Compare February 21, 2023 21:18
@alexandre-daubois alexandre-daubois force-pushed the feat-warmer-finished-event branch from e23e254 to e07eba7 Compare February 21, 2023 21:26
@nicolas-grekas nicolas-grekas force-pushed the feat-warmer-finished-event branch from e07eba7 to 5791513 Compare February 22, 2023 11:47
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit f3722d5 into symfony:6.3 Feb 22, 2023
@dkarlovi
Copy link
Contributor

Thanks for working on this @alexandre-daubois! \o/

@alexandre-daubois alexandre-daubois deleted the feat-warmer-finished-event branch February 22, 2023 11:54
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@alexislefebvre alexislefebvre alexislefebvre left review comments

Assignees
No one assigned
Labels
Feature FrameworkBundle HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.3
5 participants
@alexandre-daubois @nicolas-grekas @dkarlovi @alexislefebvre @carsonbot