[HttpKernel] Collect data from every event dispatcher #49151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e832b7 to
e00675a
Compare
|
We should not mix the listeners of various event dispatchers. That would make debugging much harder (as listeners from different dispatchers are totally separate lists). If we can profile multiple dispatchers, the webprofiler panel must display them separately (see how the mailer panel handles a project with multiple mailers configured for instance). |
|
@stof is that what you meant?
|
|
Yeah, it should look like that (and it means you won't ever mix the listeners from multiple TraceableEventDispatcher together and so you won't re-sort anything in the collector) |
792075f to
6af1697
Compare
|
Indeed; PR updated thanks! |
aac6d83 to
9770a9c
Compare
8ccd9af to
7e014a1
Compare
7e014a1 to
a6f8a00
Compare
a6f8a00 to
b69b194
Compare
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
30b7e78 to
0dd6d17
Compare
e658f9f to
cfb35e8
Compare
|
No deprecation anymore 👌 |
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/DataCollector/EventDataCollector.php
Outdated
Show resolved
Hide resolved
43164f5 to
6396377
Compare
6396377 to
a204629
Compare
a204629 to
7a77b3a
Compare
|
Thank you @MatTheCat. |
|
Thank you for finishing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #49021: instead of only passing the main event dispatcher to the
EventDataCollector, we pass them all (thanks to theevent_dispatcher.dispatchertag).(The heading is now “Dispatched Events”.)
Check “Hide whitespace” when reviewing.