[FrameworkBundle] Improve documentation about translation:extract --sort option #49189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot
approved these changes
Mar 25, 2023
…ort option The `--sort` option only works with `--dump-messages` (i.e. not with `--force`). It took me some time to realize that, and the documentation didn't help me since it was showing an example that didn't work. Contribute to symfony#37918
5300f16 to
1dbf13e
Compare
|
Thank you @marien-probesys. |
marien-probesys
added a commit
to marien-probesys/symfony
that referenced
this pull request
Dec 18, 2023
This commit reverts the change made in PR symfony#49189 as the command accepts the argument `--sort` with `--force`. Reference: symfony#49189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--sortoption only works with--dump-messages(i.e. not with--force). It took me some time to realize that, and the documentation didn't help me since it was showing an example that didn't work.It would have been better to also apply the
--sortoption to--forceas requested in #37918, but I don't have that much time to understand how to do it. At least it could save some time to people ;)It's my first PR for Symfony, so let me know if I forget something or did something wrong!