[Crawler] Fix regression where cdata nodes will return empty string #49195
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @tgalopin has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
2c88cda to
184a1d1
Compare
|
fabbot reports a code style issue regarding a comment for a parameter that is commented out - is this patch wanted, or necessary for my PR to pass? |
184a1d1 to
23c1dda
Compare
|
Thank you @NanoSector. |
Fixes a regression caused by the fix to #48682 where
<script>tags would return empty string on the innerContent call, where in 6.2 this did work.Attached is a zipped PHPUnit test case used to verify the regression on 6.2 with a screenshot of its result.
CrawlerInnerTextTest.zip
