[Security] Implemented the Serializable interface in the Role class #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a BC break for people extending the Before: After: Length is 23 vs 79 for a role. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2012
Commits ------- 1f2f866 fixed the serialization of the SwitchUserRole b55930a [Security] Implemented the Serializable interface in the Role class Discussion ---------- [Security] Implemented the Serializable interface in the Role class The Role class is serialized in the session for each role of the user. Implementing the Serializable interface allows to reduce the size of the data.
|
Oops, I did not want to merge it. I'm going to revert it now. |
fabpot
added a commit
that referenced
this pull request
Jul 15, 2012
|
@fabpot are you rejecting the PR or only keeping it pending ? In the second case, a new PR will be needed as github does not allow reopening merged PRs |
|
I'm -1 but let's the discussion continue on a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Role class is serialized in the session for each role of the user. Implementing the Serializable interface allows to reduce the size of the data.