Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[VarDumper] Disable links for IntelliJ platform #49274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

[VarDumper] Disable links for IntelliJ platform #49274

merged 1 commit into from
Mar 25, 2023

Conversation

SerafimArts
Copy link
Contributor

@SerafimArts SerafimArts commented Feb 7, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

IntelliJ IDEA / PHP Storm does not support hrefs (TBD: Perhaps only on Windows OS?)

This fix detects that the console was launched from an IDEA environment by IDEA_INITIAL_DIRECTORY env variable and disables href rendering.

Unit tests are missing, because it cannot be tested in simple ways.

UPD: Added tests by analogy with the proposal in #49274 (comment)

Before

image

After

image

@carsonbot carsonbot added this to the 5.4 milestone Feb 7, 2023
@alexislefebvre
Copy link
Contributor

Unit tests are missing, because it cannot be tested in simple ways.

Can we use something like this?

symfony/src/Symfony/Component/Console/Tests/Formatter/OutputFormatterTest.php

Line 250 in bc5fea4

putenv('TERMINAL_EMULATOR='.$terminalEmulator);

@SerafimArts SerafimArts requested a review from chalasr as a code owner February 8, 2023 00:36
@SerafimArts
Copy link
Contributor Author

@alexislefebvre Thanks, added. This allowed me to find another problem that I corrected.

@stof
Copy link
Member

stof commented Feb 8, 2023

Isn't the JetBrains-JediTerm ternminal emulator already covering the case of the IntelliJ platform ?

@SerafimArts
Copy link
Contributor Author

SerafimArts commented Feb 8, 2023 •
edited
Loading

@stof nope. Perhaps this variable is available only on the Linux, because on Windows it is not available.

I don't have x11 on my system at the moment to test this behavior from under wsl.

@alexislefebvre
Copy link
Contributor

I had the same issue with Symfony 4.4 (:see_no_evil:) and this PR helped me, thank you.

I defined this environment variable when running the tests:

image

SerafimArts added a commit to php-type-language/parser that referenced this pull request Mar 10, 2023
@SerafimArts
Replace symfony var-dumper to improved one (see symfony/symfony#49274)
6a974db
@fabpot fabpot force-pushed the feature/idea-without-cli-url branch from 8749d63 to 3670b93 Compare March 25, 2023 09:26
@fabpot fabpot force-pushed the feature/idea-without-cli-url branch from 3670b93 to f995db4 Compare March 25, 2023 09:27
@fabpot
Copy link
Member

fabpot commented Mar 25, 2023

Thank you @SerafimArts.

@fabpot fabpot merged commit 0550259 into symfony:5.4 Mar 25, 2023
This was referenced Mar 31, 2023
Merged
Merged
@MrMitch
Copy link

MrMitch commented Mar 31, 2023

@SerafimArts Sorry if that's off topic, but are you using a custom icon theme for PHPStorm ? If so, would you mind sharing it ? I really like the look and feel shown in your screenshots.

@SerafimArts
Copy link
Contributor Author

@MrMitch this is default PHPStorm icons with "One Dark Vivid" theme.

@MrMitch
Copy link

MrMitch commented Mar 31, 2023

@SerafimArts thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed VarDumper
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@SerafimArts @alexislefebvre @stof @fabpot @MrMitch @carsonbot @xabbuh