[FrameworkBundle][Yaml] Remove some unused code #49290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Feb 7, 2023
| Q | A |
|---|---|
| Branch? | 6.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
fancyweb
commented
Feb 7, 2023
| @@ -2401,10 +2401,6 @@ private function registerHttpClientConfiguration(array $config, ContainerBuilder | |||
|
|
|||
| private function registerRetryableHttpClient(array $options, string $name, ContainerBuilder $container) | |||
| { | |||
| if (!class_exists(RetryableHttpClient::class)) { | |||
There was a problem hiding this comment.
symfony/framework-bundle conflicts with symfony/http-client < 5.4`
| @@ -91,10 +91,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $this->format = $input->getOption('format'); | |||
| $flags = $input->getOption('parse-tags'); | |||
|
|
|||
| if ('github' === $this->format && !class_exists(GithubActionReporter::class)) { | |||
There was a problem hiding this comment.
symfony/yaml conflicts with symfony/console < 5.4
fabpot
approved these changes
Feb 8, 2023
a008ed5 to
8929b8e
Compare
|
Thank you @fancyweb. |
xabbuh
added a commit
that referenced
this pull request
Jan 17, 2024
This PR was submitted for the 6.4 branch but it was merged into the 7.1 branch instead. Discussion ---------- [FrameworkBundle] Remove redundant check from test | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This was overlooked in #49290. The check is no longer required since `symfony/framework-bundle` now conflicts with `symfony/http-client < 5.4` Commits ------- 4138e90 [FrameworkBundle] Remove redundant check from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.