[HttpKernel] Add skip_response_headers to the HttpCache options
#49318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Toflar
commented
Feb 9, 2023
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | #49257 |
| License | MIT |
| Doc PR |
src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Feb 10, 2023
stof
reviewed
Feb 10, 2023
| @@ -60,6 +60,9 @@ class HttpCache implements HttpKernelInterface, TerminableInterface | |||
| * on responses that don't explicitly state whether the response is | |||
| * public or private via a Cache-Control directive. (default: Authorization and Cookie) | |||
| * | |||
| * * skip_response_headers Set of response headers that are never cached even if a response is cacheable (public). | |||
There was a problem hiding this comment.
I think skipped_response_headers might be a better name for the option
There was a problem hiding this comment.
let's keep it as is, it also makes sense, is shorter and prevents reindenting all the docblock :P
There was a problem hiding this comment.
The docblock was the reason for me to keep it as short as it is now 🙈
maxhelias
approved these changes
Feb 15, 2023
skip_response_headers to the HttpCache optionsskip_response_headers to the HttpCache options
1344356 to
00dfb25
Compare
|
Thank you @Toflar. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 22, 2023
…headers` option (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Add `framework.http_cache.skip_response_headers` option | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Followup of #49318 | License | MIT | Doc PR | symfony/symfony-docs#17951 While thinking about where to add documentation for symfony/symfony-docs#17941, I realized that all HTTP Cache options are available under `framework.http_cache` config. By adding this option as well, we'll be able to write documentation about it, in the framework configuration reference. Commits ------- 010aa39 [FrameworkBundle] Add `framework.http_cache.skip_response_headers` option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.