Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BC Break] Make data providers for abstract test cases static #49368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

[BC Break] Make data providers for abstract test cases static #49368

merged 2 commits into from
Feb 17, 2023

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Feb 14, 2023 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Refs #48668
License MIT
Doc PR -

Follows #48668 (comment)

Todos

  • Bump min version in composer.json Notifier @OskarStark
  • Bump min version in composer.json Translation @OskarStark
  • Bump min version in composer.json Mailer @OskarStark
  • Bump min version in composer.json Security @OskarStark - nothing todo
  • document BC break in CHANGELOG files Notifier @OskarStark
  • document BC break in CHANGELOG files Translation @OskarStark
  • document BC break in CHANGELOG files Mailer @OskarStark
  • document BC break in CHANGELOG files Security @OskarStark
  • document BC break in UPGRADE files Notifier @OskarStark
  • document BC break in UPGRADE files Translation @OskarStark
  • document BC break in UPGRADE files Mailer @OskarStark
  • document BC break in UPGRADE files Security @OskarStark
  • remove $this in static methods @alexandre-daubois
  • make tests green

@carsonbot carsonbot added this to the 5.4 milestone Feb 14, 2023
@OskarStark OskarStark changed the title Static data providers test [BC Break] Make data providers for abstract test cases static Feb 14, 2023
OskarStark
OskarStark commented Feb 14, 2023
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Feb 14, 2023
View reviewed changes
@OskarStark OskarStark force-pushed the static-data-providers-test branch from 6d6daca to 0074829 Compare February 14, 2023 19:53
@OskarStark
Copy link
Contributor Author

Rebased

@alexandre-daubois alexandre-daubois mentioned this pull request Feb 15, 2023
Merged
@OskarStark OskarStark force-pushed the static-data-providers-test branch 2 times, most recently from 4de5115 to c233a27 Compare February 15, 2023 09:50
nicolas-grekas added a commit that referenced this pull request Feb 15, 2023
@nicolas-grekas
bug #49385 [Notifier] Make TransportTestCase data providers static …
a9c2bce 
…(alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] Make `TransportTestCase` data providers static

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Part of #49368
| License       | MIT
| Doc PR        | -

:information_source: Note: the `TransportTestCase::createTransport()` method also had to be passed to static.

cc `@OskarStark`

Commits
-------

6a9f1d0 [Notifier] Make `TransportTestCase` data providers static
@nicolas-grekas
Copy link
Member

(rebase unlocked)

@alexandre-daubois
Copy link
Member

Notifier PR against your branch as you asked is ready at OskarStark#1 👍

@OskarStark OskarStark force-pushed the static-data-providers-test branch from c233a27 to a2eaf84 Compare February 16, 2023 19:12
@OskarStark
Copy link
Contributor Author

Rebased and merged OskarStark#1 👍

nicolas-grekas
nicolas-grekas reviewed Feb 16, 2023
View reviewed changes
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 16, 2023 •
edited
Loading

please squash when pushing, it'd be great to have only two commits in the PR, one for each of you

@alexandre-daubois
Copy link
Member

I think this is the final one before having an all-green on 5.4 🙌

OskarStark#2

@OskarStark
Copy link
Contributor Author

Merged. Will squash them properly later today

@OskarStark OskarStark force-pushed the static-data-providers-test branch 2 times, most recently from cdacda5 to 3b82be0 Compare February 17, 2023 06:08
OskarStark
OskarStark commented Feb 17, 2023
View reviewed changes
OskarStark
OskarStark commented Feb 17, 2023
View reviewed changes
OskarStark
OskarStark commented Feb 17, 2023
View reviewed changes
OskarStark
OskarStark commented Feb 17, 2023
View reviewed changes
OskarStark
OskarStark commented Feb 17, 2023
View reviewed changes
@OskarStark OskarStark force-pushed the static-data-providers-test branch from 08d3fda to 1e76645 Compare February 17, 2023 09:42
@OskarStark
Copy link
Contributor Author

rebased

@nicolas-grekas nicolas-grekas force-pushed the static-data-providers-test branch from 1e76645 to a5d48f8 Compare February 17, 2023 09:57
@nicolas-grekas nicolas-grekas force-pushed the static-data-providers-test branch from a5d48f8 to c444a43 Compare February 17, 2023 10:07
@nicolas-grekas
Copy link
Member

Thank you @OskarStark.

@nicolas-grekas nicolas-grekas merged commit 29f46fc into symfony:5.4 Feb 17, 2023
@OskarStark OskarStark deleted the static-data-providers-test branch February 17, 2023 11:11
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
BC Break Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @nicolas-grekas @alexandre-daubois @carsonbot