Fix PHPUnit 9.6 deprecations #49381
Merged
Fix PHPUnit 9.6 deprecations #49381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 15, 2023
xabbuh
approved these changes
Feb 15, 2023
|
Thank you @derrabus. |
stof
reviewed
Feb 15, 2023
| @@ -311,12 +311,25 @@ public function testNullSafeEvaluateFails($expression, $foo, $message) | |||
| /** | |||
| * @dataProvider provideInvalidNullSafe | |||
| */ | |||
| public function testNullSafeCompileFails($expression, $foo) | |||
| public function testNullSafeCompileFails($expression) | |||
There was a problem hiding this comment.
$foo should not be removed. It is used by the eval'd code.
nicolas-grekas
added a commit
that referenced
this pull request
Feb 15, 2023
This PR was merged into the 6.2 branch. Discussion ---------- [ExpressionLanguage] add missing variable | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #49381 (comment) | License | MIT | Doc PR | Commits ------- e9955e5 add missing variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecations introduced by PHPUnit 9.6. We should merge this PR before merging up #49233.