[DependencyInjection] Add AsAlias attribute #49411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Really nice thank you!
src/Symfony/Component/DependencyInjection/Attribute/AsAlias.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/FileLoader.php
Outdated
Show resolved
Hide resolved
649aac1 to
3fcf97a
Compare
Contributor
Author
|
Changes done, thanks for the review 🙂 |
nicolas-grekas
approved these changes
Feb 16, 2023
src/Symfony/Component/DependencyInjection/Tests/Loader/FileLoaderTest.php
Outdated
Show resolved
Hide resolved
3fcf97a to
a82aeb1
Compare
chalasr
approved these changes
Feb 18, 2023
chalasr
reviewed
Feb 18, 2023
eea6905 to
fe63d39
Compare
fe63d39 to
80d8cc1
Compare
Member
|
Thank you @alanpoulain. |
xabbuh
reviewed
Feb 19, 2023
| ]]; | ||
| yield 'Multiple with id' => ['PrototypeAsAlias/{WithAsAliasIdMultipleInterface,AliasBarInterface,AliasFooInterface}.php', [ | ||
| AliasBarInterface::class => new Alias(WithAsAliasIdMultipleInterface::class), | ||
| AliasFooInterface::class => new Alias(WithAsAliasIdMultipleInterface::class), |
Member
There was a problem hiding this comment.
Why is the AliasFooInterface being registered? Is it because of the WithAsAliasIdMultipleInterface class being the only one implementing this interface?
Contributor
Author
There was a problem hiding this comment.
Yes. I think it's the right behavior, don't you think so? The other possibility would be to prevent the singly implemented interface registration if there is an AsAlias attribute on the class.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
AsAliasattribute for defining an alias on a service:If no parameter is used in the attribute and if there is only one implemented interface, it takes this interface for the alias:
is equivalent to:
This implementation follows @nicolas-grekas suggestion in #49361: doing it in
FileLoader::registerClasses()allows to check if there is no collision.