[DependencyInjection] Fix dumping closure of service closure #49413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
… closure (fancyweb) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Improve dumping closure of service closure | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replaces #49413 as an improvement Dumping `(...)` at the end of a `\Closure` is useless. Commits ------- 49ce885 [DependencyInjection] Improve dumping closure of service closure
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Feb 21, 2023
… closure (fancyweb) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Improve dumping closure of service closure | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replaces symfony/symfony#49413 as an improvement Dumping `(...)` at the end of a `\Closure` is useless. Commits ------- 49ce885db8 [DependencyInjection] Improve dumping closure of service closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
closure(service_closure(MyService::class)), I'm expecting to get a wrapping closure of the service closure, not directly the service closure.If it's not a valid use case at all, then we have to deprecate it because it's really misleading 😓