Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Improve dumping closure of service closure #49426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

[DependencyInjection] Improve dumping closure of service closure #49426

merged 1 commit into from
Feb 21, 2023

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Replaces #49413 as an improvement

Dumping (...) at the end of a \Closure is useless.

@carsonbot carsonbot added this to the 6.3 milestone Feb 17, 2023
Ahummeling
Ahummeling approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Ahummeling Ahummeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too often have I tried to click on these ..., hoping they would expand to the function body, known full well they won't.

@fancyweb fancyweb force-pushed the di/improve-dumping-closure-of-service-closure branch from ff7ccca to 49ce885 Compare February 21, 2023 12:21
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 798efba into symfony:6.3 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Ahummeling Ahummeling Ahummeling approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @Ahummeling @carsonbot