Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Add option to enable Sandbox via dsn option sandbox=true #49429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

[Mailer] Add option to enable Sandbox via dsn option sandbox=true #49429

merged 1 commit into from
Feb 21, 2023

Conversation

mdawart
Copy link
Contributor

@mdawart mdawart commented Feb 17, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes/no
Deprecations? no
Tickets Fix #49410
License MIT
Doc PR -

Mailjet introduced a Sandbox Mode https://dev.mailjet.com/email/guides/send-api-v31/#sandbox-mode that allows to use the API but not sending any email e.g. for debugging.

MAILER_DSN=mailjet+api://$PUBLIC_KEY:$PRIVATE_KEY@default?sandbox=true

@carsonbot carsonbot added this to the 6.3 milestone Feb 17, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Ahummeling
Ahummeling reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Ahummeling Ahummeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the implementation looks fine to me. I had a few minor suggestions and I was wondering if you could write a test case that considers the sandbox to be active.

@mdawart mdawart mentioned this pull request Feb 20, 2023
Closed
nicolas-grekas
nicolas-grekas reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I just have minor comments

src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetTransportFactoryTest.php Outdated
];

yield [
new Dsn('mailjet+api', 'example.com', self::USER, self::PASSWORD),
(new MailjetApiTransport(self::USER, self::PASSWORD, self::getClient(), $dispatcher, $logger))->setHost('example.com'),
(new MailjetApiTransport(self::USER, self::PASSWORD, self::getClient(), $dispatcher, $logger, false))->setHost('example.com'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes on this file are not needed and should be reverted

src/Symfony/Component/Mailer/Bridge/Mailjet/CHANGELOG.md Outdated
@@ -1,6 +1,10 @@
CHANGELOG
=========

6.3
-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra - should be removed

@carsonbot carsonbot changed the title Add option to enable Sandbox via dsn option sandbox=true [Mailer] Add option to enable Sandbox via dsn option sandbox=true Feb 21, 2023
@nicolas-grekas
Copy link
Member

Thank you @mdawart.

@nicolas-grekas nicolas-grekas merged commit fb03495 into symfony:6.3 Feb 21, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 21, 2023
Closed
@OskarStark
Copy link
Contributor

image

The toString() method should reflect the sandbox parameter if set

@alexandre-daubois alexandre-daubois mentioned this pull request Feb 21, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Feb 21, 2023
@nicolas-grekas
minor #49479 [Mailer] Reflect sandbox state in `MailjetApiTransport::…
bacb274 
…__toString()` (alexandre-daubois)

This PR was merged into the 6.3 branch.

Discussion
----------

[Mailer] Reflect sandbox state in `MailjetApiTransport::__toString()`

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #49429 (comment)
| License       | MIT
| Doc PR        | _NA_

Follow-up of #49429

8.2 tests failure seems unrelated.

Commits
-------

2d56efa [Mailer] Reflect sandbox state in `MailjetApiTransport::__toString()`
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Ahummeling Ahummeling Ahummeling approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

[Mailer][Mailjet] MailjetApiTransport Sandbox Mode
5 participants
@mdawart @carsonbot @nicolas-grekas @OskarStark @Ahummeling