[Mailer][Translation] Remove some static occurrences that may cause unstable tests
#49431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54b6b57 to
e8b83e5
Compare
static occurrences that may cause unstable testsstatic occurrences that may cause unstable tests
e8b83e5 to
872abc6
Compare
stof
approved these changes
Feb 17, 2023
static occurrences that may cause unstable testsstatic occurrences that may cause unstable tests
OskarStark
approved these changes
Feb 18, 2023
|
@alexandre-daubois Can you have a look at the failing tests? |
0653bc7 to
ea342f8
Compare
|
@fabpot I fixed tests by adding |
|
For your information, we never backport pull requests. |
|
Right! This one's a bit special as this was a request from Nicolas to target 6.3 before backporting it. I'll do the appropriate updates if this needs to be changed 🙂 |
ea342f8 to
a20b219
Compare
… may cause unstable tests
a20b219 to
2ca9cf8
Compare
|
Thank you @alexandre-daubois. |
|
Thank you for the changes! 🙏 |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
…hat may cause unstable tests (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests. Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods. The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again! ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well. Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed. Commits ------- 2ca9cf8 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
…hat may cause unstable tests (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests. Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods. The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again! ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well. Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed. Commits ------- 2ca9cf8 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
* 5.4: minor #49431 [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests (alexandre-daubois) [Workflow] remove new lines from workflow metadata Fix phpdocs in HttpClient, HttpFoundation, HttpKernel, Intl components [WebProfilerBundle] Render original (not encoded) email headers
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
* 6.2: minor #49431 [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests (alexandre-daubois) minor #49431 [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests (alexandre-daubois) [Clock] fix url in README.md [Workflow] remove new lines from workflow metadata Fix phpdocs in HttpClient, HttpFoundation, HttpKernel, Intl components [WebProfilerBundle] Render original (not encoded) email headers improve deprecation message [Console] fix clear of section with question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a little tchat with @nicolas-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests.
Helper classes doing so, found in
TranslationandMailer, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods.The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again!
ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well.
Finally, I updated
SmsapiTransportFactoryTest::missingRequiredOptionProvider. As thefromoption has been made optional, the only dataset provided failed.