Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] fix tests #49437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2023
Merged

[Notifier] fix tests #49437

merged 1 commit into from
Feb 18, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 18, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh requested a review from OskarStark as a code owner February 18, 2023 10:47
@carsonbot carsonbot added this to the 6.3 milestone Feb 18, 2023
xabbuh
xabbuh commented Feb 18, 2023
View reviewed changes
src/Symfony/Component/Notifier/Bridge/Smsapi/Tests/SmsapiTransportFactoryTest.php
@@ -90,11 +90,6 @@ public static function incompleteDsnProvider(): iterable
yield 'missing token' => ['smsapi://host.test?from=testFrom'];
}

public static function missingRequiredOptionProvider(): iterable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #49261

@xabbuh xabbuh merged commit a034e6d into symfony:6.3 Feb 18, 2023
@xabbuh xabbuh deleted the notifier-tests branch February 18, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Notifier Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@xabbuh @carsonbot