[FrameworkBundle] Allow disabling dumping of container to XML to improve performance #49487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debug mode, when the container is compiled, an XML file is automatically generated. This file is used by various commands like: - `debug:container` - `lint:container` - `config:dump-reference` - `debug:autowiring` - `debug:router` But generating this file comes with a price. When your container grows, the XML file grows, and the time to compile this file increases. In our large application this file became 20MB and took 2 seconds to generate every time the cache needed to be recompiled. For us, the benefit of this file does not outweigh the decrease in performance. Therefore I'd like to disable this dumping and accept the consequences for less debug possibilities. To disable this, one can set the `debug.container.dump` parameter to `false`.
9a32f69 to
467fb3d
Compare
|
Failing fabpot.io check is unrelated to this PR. |
nicolas-grekas
approved these changes
Feb 22, 2023
|
Thank you @ruudk. |
Merged
|
Note that this XML dump is also needed by Symfony plugin for PHPStorm for its DIC related features. It'd probably be worth listing the main known limitations this brings in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode, when the container is compiled, an XML file is automatically generated. This file is used by various commands like:
debug:containerlint:containerconfig:dump-referencedebug:autowiringdebug:routerBut generating this file comes with a price. When your container grows, the XML file grows, and the time to compile this file increases.
In our large application this file became 20MB and took 2 seconds to generate every time the cache needed to be recompiled. For us, the benefit of this file does not outweigh the decrease in performance.
Therefore I'd like to disable this dumping and accept the consequences for less debug possibilities.
To disable this, one can set the
debug.container.dumpparameter tofalse.