[DependencyInjection] Preserve the id of decorated services #49622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Mar 6, 2023
… convention (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Translation] Decouple TranslatorPathsPass from "debug." convention | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Needed to make #49622 green. Commits ------- 0a12ee6 [Translation] Decouple TranslatorPathsPass from "debug." convention
3522d0b to
4793562
Compare
4793562 to
09bc95a
Compare
derrabus
approved these changes
Mar 6, 2023
fancyweb
reviewed
Mar 7, 2023
| @@ -22,11 +22,23 @@ | |||
| */ | |||
| class ResolveReferencesToAliasesPass extends AbstractRecursivePass | |||
| { | |||
| public function __construct( | |||
| private ?DecoratorServicePass $decoratorPass = null, | |||
There was a problem hiding this comment.
Suggested change
| private ?DecoratorServicePass $decoratorPass = null, | |
| private readonly ?DecoratorServicePass $decoratorPass = null, |
| /** | ||
| * @var array<string, string> | ||
| */ | ||
| public array $decoratedServices = []; |
There was a problem hiding this comment.
Suggested change
| public array $decoratedServices = []; | |
| private array $decoratedServices = []; |
|
Thanks for the reviews. I figured out during the night that a less invasive approach might be preferred. See #49625 |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 8, 2023
…as-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Keep track of decorated ids | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When a service "foo" is decorated by a service "bar", all references to "foo" are replaced by references to "bar". This has visible side effects e.g. when running `debug:autowiring`, before this PR: ``` Symfony\Contracts\HttpClient\HttpClientInterface (.debug.http_client) ``` After: ``` Symfony\Contracts\HttpClient\HttpClientInterface (http_client) ``` Details matter ;) This PR replaces #49622 since it's a less invasive way to achieve this behavior. Commits ------- 1ac07d3 [DependencyInjection] Keep track of decorated ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a service "foo" is decorated by a service "bar", all references to "foo" are replaced by references to "bar".
This has visible side effects e.g. when running
debug:autowiring, before this PR:After:
Details matter ;)