[DomCrawler] Improve html5Parser tests #49669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
suggested changes
Mar 10, 2023
src/Symfony/Component/DomCrawler/Tests/Html5ParserCrawlerTest.php
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
61
| $this->assertNotEquals($nativeCrawler->filterXPath('//h1')->text(), $html5Crawler->filterXPath('//h1')->text(), 'Native parser and Html5 parser must be different'); | ||
| } |
There was a problem hiding this comment.
Shouldn't this prior test (testHtml5ParserNotSameAsNativeParserForSpecificHtml) be removed now?
There was a problem hiding this comment.
Hmm, that's not a perfect test but it still validating a certain behaviour of the domCrawler component and can be interesting to keep ?
There was a problem hiding this comment.
Yes, this test case is useful to me, it tests the behavior and that's what we need also.
If the behavior of the xml parser changes, we'll know also, and this is good.
|
Thank you @victor-prdh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
As mentioned by @Bilge in #49121 (comment), test to ensure the new html5Parser strategy wasn't the best ! So i worked a little on this subject and i come with this new proposal !
Thanks