-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client #49691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FrameworkBundle] Add scoped httplug clients and deprecate httplugs use like psr18 client #49691
Conversation
Thanks for working on this. |
It was my last iteration step as well. My thought process was, if I deprecate the service meant to use this method I kinda deprecate its right to exist as well and should make that official. My idea is to move the |
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
d378946
to
a7b11f8
Compare
That's two very different things to me. Removing an autowiring alias just sends a message saying that in the context of symfony apps (where we have some authority), we're discouraging using this interface. On the broader php ecosystem, we don't, and thus we can't. |
Ok got it, I have to see the remaining use outside of a symfony bundle integration. 👍 |
5e20465
to
5c81cb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add two (short) lines in the changelog of FrameworkBundle: one for the new aliases, one for the deprecation
src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php
Outdated
Show resolved
Hide resolved
…se like psr18 client
bec8ee7
to
20ab567
Compare
Thank you @simonberger. |
This MR does 2 closely related things to try to fully integrate the HttplugClient with the unique features it brings and on the other hand deprecate its use like a psr18 client which it is in a pending deprecation state since a long time.
httplug.http_client
and aliasHttp\Client\HttpAsyncClient
to inject the theHttplugClient
.Http\Client\HttpClient
a deprecated alias of it