[FrameworkBundle] Add support to easily clear all cache pools #49705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bb7d23 to
9f2be24
Compare
|
quick reminder that new features require PR in symfony/symfony-docs as well ;) |
You're absolutely right, I should have mentioned I will make that addition when I at least know this is going to be accepted in some form. The issue I link might indicate that already, but as it was quite old I find it best to have confirmation first :) Test errors look to be unrelated by the way. |
src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 17, 2023
fabpot
approved these changes
Mar 25, 2023
4caa884 to
3a50d2d
Compare
|
Thank you @bobvandevijver. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Mar 29, 2023
…for `cache:pool:clear` (bobvandevijver) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Cache] Add documentation for new `--all` option for `cache:pool:clear` <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Documentation update for symfony/symfony#49705. Commits ------- bb7796d [Cache] Add documentation for new `--all` option for `cache:pool:clear`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #22047, I've now added a
--alloption to clear all cache pools by just providing that argument tocache:pool:clear. I believe this is more convenient than remembering thecache.global_clearerclearer alias and more descriptive for the consumer.