-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Add support for the DelayStamp in InMemoryTransport #49725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:6.3
from
fabpot:in-memory-messenger-delay-stamp-support
Mar 19, 2023
Merged
[Messenger] Add support for the DelayStamp in InMemoryTransport #49725
fabpot
merged 1 commit into
symfony:6.3
from
fabpot:in-memory-messenger-delay-stamp-support
Mar 19, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Mar 18, 2023
Q | A |
---|---|
Branch? | 6.3 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | n/a |
License | MIT |
Doc PR | n/a |
welcoMattic
approved these changes
Mar 18, 2023
src/Symfony/Component/Messenger/Transport/InMemory/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
29511ca
to
3bd8602
Compare
OskarStark
reviewed
Mar 19, 2023
$this->serializer = $serializer; | ||
public function __construct( | ||
private ?SerializerInterface $serializer = null, | ||
private ?ClockInterface $clock = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this as require dev dep? Or is it already available?
src/Symfony/Component/Messenger/Transport/InMemory/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/InMemory/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Transport/InMemory/InMemoryTransport.php
Outdated
Show resolved
Hide resolved
3bd8602
to
c57c971
Compare
c57c971
to
1025f35
Compare
nicolas-grekas
approved these changes
Mar 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.