Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ErrorHandler] do not serialize collected properties in FlattenException #49736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 19, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

see the currently failing tests of the SecurityBundle

@nicolas-grekas
Copy link
Member

This breaks the properties thing as soon as the flatten-exception is unserialized, isn't it?

Can't we use __serialize/__unserialize instead? This might break child classes of FlattenException because __sleep doesn't work with them.

I think a better course of action could have been to put a VarDumper's Data object instead of what is currently done, or to convey the properties outside of the FlattenException is possible? Maybe via a child class actually?

If we use a Data object, the serialized payload can potentially be huge (as is the case after #49620, ignoring unserializable values.)

/cc @lyrixx for thoughts

@nicolas-grekas
Copy link
Member

I gave my comments a try and submitted #49746 instead. Thanks for giving this a try!

@xabbuh xabbuh deleted the pr-49620 branch March 20, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants