[FrameworkBundle] Fix wiring session.handler when handler_id is null #49745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f999d42 to
37eba66
Compare
GromNaN
reviewed
Mar 20, 2023
| ini_set('session.save_path', $savePath); | ||
| ini_set('session.save_handler', 'files'); | ||
| if ($savePath !== \ini_get('session.save_path')) { | ||
| ini_set('session.save_path', $savePath); |
There was a problem hiding this comment.
Why do you need to check if different before setting the config?
There was a problem hiding this comment.
it's not exactly needed for the fix, but this might remove useless "ini_set(): Session ini settings cannot be changed when a session is active".
37eba66 to
e23be58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the session
handler_idis null, we currently set the$handlerargument of the storage/factory services to null, which means to them "create your own handler internally from the native one". This means that thesession.handlerservice is "a lie": it's not the real handler used by the storage. It also means that the%session.save_path%parameter is lying too, because it is set to%kernel.cache_dir%/sessions(by default), while the storage will useini_get('session.save_path')in practice.This issue is 10 years old... #5290