Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Use file system completion for redirect operators #49762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

[Console] Use file system completion for redirect operators #49762

merged 1 commit into from
Mar 25, 2023

Conversation

Chi-teck
Copy link
Contributor

@Chi-teck Chi-teck commented Mar 21, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
Tickets #49761
License MIT

The approach is similar to systemd/systemd#12089. I also added input redirect operator.

@Chi-teck Chi-teck requested a review from chalasr as a code owner March 21, 2023 18:25
@carsonbot carsonbot added this to the 6.3 milestone Mar 21, 2023
@carsonbot carsonbot changed the title Use file system completion for redirect operators [Console] Use file system completion for redirect operators Mar 21, 2023
@GromNaN
Copy link
Member

GromNaN commented Mar 21, 2023 •
edited
Loading

Thanks for working on this topic. It would be nice if we can have the same feature for fish and zsh.

I'll use a demo app to test.

@Chi-teck Chi-teck mentioned this pull request Mar 22, 2023
Closed
3 tasks
@Chi-teck
Copy link
Contributor Author

@GromNaN I have no experience with ZSH or Fish. So added subtasks to the parent ticket.

GromNaN
GromNaN approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well. Thank you.

@fabpot
Copy link
Member

fabpot commented Mar 25, 2023

Thank you @Chi-teck.

@fabpot fabpot merged commit 26f209d into symfony:6.3 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Chi-teck @GromNaN @fabpot @carsonbot