[Console] Add missing ZSH mention in DumpCompletionCommand help #49765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
commented
Mar 22, 2023
src/Symfony/Component/Console/Command/DumpCompletionCommand.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Mar 22, 2023
| @@ -55,7 +55,7 @@ protected function configure() | |||
| $this | |||
| ->setHelp(<<<EOH | |||
| The <info>%command.name%</> command dumps the shell completion script required | |||
| to use shell autocompletion (currently, bash and fish completion is supported). | |||
| to use shell autocompletion (currently, bash, zsh and fish completion are supported). | |||
There was a problem hiding this comment.
maybe this list should be generated from $this->getSupportedShells(), to avoid having to remember this help text each time we add a new supported shell.
There was a problem hiding this comment.
Oups, I forgot this PR! Fixed!
34f3653 to
8ae562e
Compare
8ae562e to
fd957a9
Compare
fabpot
approved these changes
Mar 28, 2023
|
Thank you @lyrixx. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/symfony/symfony/blob/6.2/src/Symfony/Component/Console/Resources/completion.zsh
And I check, it doesn't exist on 5.4