Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Pass the port from the Mailgun DSN to the MailgunSmtpTransport #49768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Mailer] Pass the port from the Mailgun DSN to the MailgunSmtpTransport #49768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d69d4b
Pass the port from the Mailgun DSN to the MailgunSmtpTransport
Mar 22, 2023
ff5469e
Update method usage in tests
Mar 22, 2023
0eecc0c
Add space to comply with code styles
Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Mailer/Bridge/Mailgun/Tests/Transport/MailgunTransportFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ public static function createProvider(): iterable

yield [
new Dsn('mailgun+smtp', 'default', self::USER, self::PASSWORD),
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, $logger),
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, null, $logger),
];

yield [
new Dsn('mailgun+smtps', 'default', self::USER, self::PASSWORD),
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, $logger),
new MailgunSmtpTransport(self::USER, self::PASSWORD, null, null, null, $logger),
];
}

Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunSmtpTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ class MailgunSmtpTransport extends EsmtpTransport
{
use MailgunHeadersTrait;

public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $username, #[\SensitiveParameter] string $password, string $region = null, int $port = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
{
parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', 465, true, $dispatcher, $logger);
parent::__construct('us' !== ($region ?: 'us') ? sprintf('smtp.%s.mailgun.org', $region) : 'smtp.mailgun.org', $port ?? 465, true, $dispatcher, $logger);

$this->setUsername($username);
$this->setPassword($password);
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Mailer/Bridge/Mailgun/Transport/MailgunTransportFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function create(Dsn $dsn): TransportInterface
}

if ('mailgun+smtp' === $scheme || 'mailgun+smtps' === $scheme) {
return new MailgunSmtpTransport($user, $password, $region, $this->dispatcher, $this->logger);
return new MailgunSmtpTransport($user, $password, $region, $port, $this->dispatcher, $this->logger);
}

throw new UnsupportedSchemeException($dsn, 'mailgun', $this->getSupportedSchemes());
Expand Down