Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] Add container.excluded tag on classes autodiscovered but excluded #49788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

Tiriel
Copy link
Contributor

@Tiriel Tiriel commented Mar 23, 2023

Add container.excluded tag on classes autodiscovered but excluded by #[Exclude] or #[When] attributes

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #49764
License MIT
Doc PR -

As per ticket, adding container.excluded tag on classes autodiscovered but excluded by one of the two attributes.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Tiriel
Copy link
Contributor Author

Tiriel commented Mar 24, 2023

Some test seem to be failing with no related reason to this PR. Actually, one test did start to fail only with the second commit, which was only code styling.

The other fail concerns a comment not needed yet, which was added for a method argument commented for now.

@nicolas-grekas
Copy link
Member

Thank you @Tiriel.

@nicolas-grekas nicolas-grekas merged commit fdbd4c1 into symfony:6.3 Mar 28, 2023
@Tiriel Tiriel deleted the ticket_49764 branch March 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tag "container.exclude" to auto-discovered classes excluded wy #[Exclude] / #[When]
3 participants