Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Fix MissingConstructorArgumentsException returning missing argument one by one #49832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Serializer] Fix MissingConstructorArgumentsException returning missing argument one by one #49832

merged 1 commit into from
Apr 21, 2023

Conversation

ktherage
Copy link
Contributor

@ktherage ktherage commented Mar 27, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR is an improvment of #49013 and fix #42712.

She aims to fix the problem reported in #49013 indicating that the method getMissingConstructorArguments() of \Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException class introduced in #42712 is returning only one missing arguments when there's more than one missing.

@ktherage ktherage requested a review from dunglas as a code owner March 27, 2023 14:49
@carsonbot carsonbot added this to the 6.3 milestone Mar 27, 2023
@nicolas-grekas
Copy link
Member

/cc @HypeMC FYI

@ktherage
Copy link
Contributor Author

/cc @BafS also

@HypeMC
Copy link
Contributor

HypeMC commented Mar 27, 2023

The original goal of my PR was to add the class as an argument to the exception, this reverts that as well. While I like the idea of having all the arguments at once, I don't see why the part with the class being passed needs to be removed.

@ktherage
Copy link
Contributor Author

@HypeMC

The original goal of my PR was to add the class as an argument to the exception, this reverts that as well.

Well, sorry, I missed that part I'll check that.

@ktherage ktherage force-pushed the fix-missing-constructor-arguments-exception branch from ada843a to 5dc7445 Compare March 27, 2023 16:57
@ktherage
Copy link
Contributor Author

ktherage commented Mar 27, 2023 •
edited
Loading

I have a failing test locally and I think that it's fine as it requires now a constructor parameter that is missing but I'm not sure if I might fix it (ie I actually broke a thing).

It's at src/Symfony/Component/Serializer/Tests/SerializerTest.php:764

details :

1) Symfony\Component\Serializer\Tests\SerializerTest::testUnionTypeDeserializableWithoutAllowedExtraAttributes
Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException: Cannot create an instance of "Symfony\Component\Serializer\Tests\DummyCTypeForUnion" from serialized data because its constructor requires the following parameters to be present : "c".

/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php:408
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:244
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:323
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Serializer.php:227
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:537
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:601
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php:370
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:244
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php:323
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Serializer.php:227
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Serializer.php:145
/home/ktherage/Documents/forks/symfony/src/Symfony/Component/Serializer/Tests/SerializerTest.php:764

@ktherage ktherage force-pushed the fix-missing-constructor-arguments-exception branch from 371daec to 8998701 Compare March 28, 2023 09:46
@ktherage ktherage force-pushed the fix-missing-constructor-arguments-exception branch from 1ff6b4a to 0f3622a Compare April 21, 2023 07:32
@nicolas-grekas nicolas-grekas force-pushed the fix-missing-constructor-arguments-exception branch from e1b891c to 43d028d Compare April 21, 2023 15:29
@nicolas-grekas
Copy link
Member

Thank you @ktherage.

@nicolas-grekas nicolas-grekas merged commit b8e918d into symfony:6.3 Apr 21, 2023
@ktherage ktherage deleted the fix-missing-constructor-arguments-exception branch April 26, 2023 07:09
@HypeMC HypeMC mentioned this pull request Oct 9, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Oct 17, 2023
@nicolas-grekas
bug #51907 [Serializer] Fix collecting only first missing constructor…
bccdccc 
… argument (HypeMC)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Serializer] Fix collecting only first missing constructor argument

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT

Alternative to #51866, sort of followup to #49832

Currently on 5.4 only the first exception is added to the `not_normalizable_value_exceptions` array when `COLLECT_DENORMALIZATION_ERRORS` is `true` or only the first argument is mentioned in the `MissingConstructorArgumentsException` when it is `false`.
On 6.3 however, the part with the `MissingConstructorArgumentsException` was fix with #49832, but the part with the `not_normalizable_value_exceptions` was overlooked.
IMO this is inconsistent behavior as the two cases are actually the same thing with the only difference being that in one case an exception is thrown while in the other the errors are collected.

I'm not sure if #51866 really qualifies as a bug or is actually more a feature, but the reason #49832 was merged onto 6.3 was because of the changes originally done in #49013, which itself was a feature.

If #51866 does qualify as a bug then it would make sense to backport #49832 to 5.4 for consistency, which is what this PR does.

The PR contains two commits:
1) backport of #49832
2) alternative to #51866

If #51866 does not qualify as a bug, the first commit can be drooped and the second one can be rebased with 6.4.

PS I think it's easier to review the changes commit by commit.

Commits
-------

0f398ce [Serializer] Fix collecting only first missing constructor argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@HypeMC HypeMC HypeMC left review comments

@mtarld mtarld mtarld left review comments

@WebMamba WebMamba WebMamba left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ktherage @nicolas-grekas @HypeMC @mtarld @WebMamba @carsonbot