[FrameworkBundle] Fix services usages output for text descriptor #49849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +361,7 @@ protected function describeContainerDefinition(Definition $definition, array $op | |||
| } | |||
|
|
|||
| $inEdges = null !== $builder && isset($options['id']) ? $this->getServiceEdges($builder, $options['id']) : []; | |||
| $tableRows[] = ['Usages', $inEdges ? implode(', ', $inEdges) : 'none']; | |||
| $tableRows[] = ['Usages', $inEdges ? implode(\PHP_EOL, $inEdges) : 'none']; | |||
There was a problem hiding this comment.
what about limiting to eg 3 and show "and X more" instead? I agree with you that the long output is useless
There was a problem hiding this comment.
@nicolas-grekas, I was thinking about it, but isn't it the main reason of debug command to clearly show the details about the resource?
Another option I thought was to implement a new command argument which would show usages (similar to show-arguments), but this would result to BC break, because by default it would no longer show usages..
IMO leaving all usages, but showing them in a single column is better (attaching screenshots of differences)
WDYT?
nicolas-grekas
approved these changes
Mar 31, 2023
fabpot
approved these changes
Mar 31, 2023
|
Thank you @rmikalkenas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If service is being used by lots of other services, the debug container command becomes unreadable, because
Usagesexpands table. Replacing,separator with new line fixes this issue