[HttpClient] Preserve MockResponse reference in MockHttpClient #49874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting yes. Is the failure on AmazonSqs related? |
|
wouldn't this break if the client does 2 requests ? |
Yes, it's related. The problem is that MockResponse passed as a response factory to MockHttpClient with status code >= 300 now throws on destruct because they have an initializer 😞
Do you mean providing one MockResponse to MockHttpClient and calling ->request() 2 times? |
|
@fancyweb yes |
|
This case is already not working, it throws |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 19, 2023
…ancyweb) This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient] Improve MockHttpClient exception message | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #49874 (comment) | License | MIT | Doc PR | - When using `MockHttpClient`, if there are more requests done on the client than the passed available responses, the exception message is misleading. ~Targeting 5.4 since it only changes the exception message 😅~ Commits ------- bd5a4ca [HttpClient] Improve MockHttpClient exception message
symfony-splitter
pushed a commit
to symfony/http-client
that referenced
this pull request
Apr 19, 2023
…ancyweb) This PR was merged into the 6.3 branch. Discussion ---------- [HttpClient] Improve MockHttpClient exception message | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#49874 (comment) | License | MIT | Doc PR | - When using `MockHttpClient`, if there are more requests done on the client than the passed available responses, the exception message is misleading. ~Targeting 5.4 since it only changes the exception message 😅~ Commits ------- bd5a4caef4 [HttpClient] Improve MockHttpClient exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's possible to return the same reference with this strategy. WDYT?