[Serializer] Make ProblemNormalizer give details about ValidationFailedException and PartialDenormalizationException
#49944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79350ed to
61b7853
Compare
This was referenced Apr 5, 2023
d43fb8b to
0b7bc3d
Compare
lyrixx
reviewed
Apr 5, 2023
src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php
Outdated
Show resolved
Hide resolved
e82ef12 to
1dde120
Compare
WebMamba
reviewed
Apr 5, 2023
1dde120 to
8b0a1bc
Compare
stof
reviewed
Apr 5, 2023
src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php
Outdated
Show resolved
Hide resolved
8b0a1bc to
1383671
Compare
stof
approved these changes
Apr 5, 2023
1383671 to
f19bdbe
Compare
…ailedException` and `PartialDenormalizationException`
f19bdbe to
576f026
Compare
|
Great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some infrastructure that I think is missing and would be nice using in #49138
With this patch, if an
HttpExceptionis thrown and if it wraps either aValidationFailedExceptionor aPartialDenormalizationException, Symfony will return a JSON containing the details of the validation failures / missing properties when the request comes withAccept: application/json.I also fixed a few minor things that I found while digging the code on this topic.