-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel] Introduce #[MapUploadedFile]
controller argument attribute
#49978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
66e8f09
to
f366d35
Compare
Wow, I like idea of reusing infrastructure provided by Can you add support of the variadic arguments? + squash your commits for easier review until my PR hasn't merged. |
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Outdated
Show resolved
Hide resolved
b6fa35a
to
cb5a76f
Compare
I Just added support to variadic arguments and the commits were squashed. @Koc
Status code changed to 422. @GromNaN |
@renedelima you can rebase now 🎉 |
75aad23
to
9eb9b53
Compare
Rebased. For now, it seems there are no more suggestions to consider. Let's see what people have to say. |
9eb9b53
to
d881c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could also be great to have unit tests in RequestPayloadValueResolverTest
.
6312aee
to
0a29c3a
Compare
b3a06fb
to
9701c13
Compare
9e64462
to
dc068fb
Compare
Anyone @symfony/mergers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It looks like your commiter email is not associated with your GitHub account, maybe you want to change that? |
...ony/Component/HttpKernel/Tests/Controller/ArgumentResolver/UploadedFileValueResolverTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Outdated
Show resolved
Hide resolved
e96d7ee
to
e3f43a0
Compare
#[MapUploadedFile]
controller argument attribute
e3f43a0
to
35583a6
Compare
Signed-off-by: Rene Lima <[email protected]>
35583a6
to
b85dbd0
Compare
1 year later. Thanks for your work and your endurance @renedelima! |
Usage Example