Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the list of supported shells for completions in a phar #50111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix the list of supported shells for completions in a phar #50111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix the list of supported shells for completions in a phar 
Using glob inside a phar does not work (it does not find anything).
Using a DirectoryIterator on the other hand works with phars. This
allows this command to compute the list of supported shells properly
when used inside a phar.
  • Loading branch information
@stof
stof committed Apr 21, 2023
commit aabdc2001112e61487dbe1dcc6c7bf8f3d738ca4
12 changes: 9 additions & 3 deletions src/Symfony/Component/Console/Command/DumpCompletionCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,14 @@ private function tailDebugLog(string $commandName, OutputInterface $output): voi
*/
private function getSupportedShells(): array
{
return array_map(function ($f) {
return pathinfo($f, \PATHINFO_EXTENSION);
}, glob(__DIR__.'/../Resources/completion.*'));
$shells = [];

foreach (new \DirectoryIterator(__DIR__.'/../Resources/') as $file) {
if (str_starts_with($file->getBasename(), 'completion.') && $file->isFile()) {
$shells[] = $file->getExtension();
}
}

return $shells;
}
}