[Scheduler] Make MessageGenerator yield some scheduling context
#50130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MessageGenerator to yield some contextMessageGenerator yield some scheduling context
7a21297 to
7452f8a
Compare
And add it to the ScheduledStamp in case of use within Messenger. Replaces 50096 Fix 50085 This approach allows to provie some context that the message consumers can use or not depending on its use case
7452f8a to
3664d08
Compare
fabpot
approved these changes
Apr 24, 2023
|
Thank you @tucksaun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
MessageContextthatMessageGeneratorshould use as key when yielding messages to provide more context about the scheduled message.The consumer of the scheduled messages can decide to use it or not.
The PR also adds the wiring to add this context to the
ScheduledStampwhen using Scheduler within Messenger.This allows to add more context but without introducing a hard dependency on Messenger.
/cc @kbond
Note: this PR is not adding the scheduler name (cf #49864) because I don't know exactly where to wire it yet but I don't see anything preventing it to be added to the context once we know where it should belong.