Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Scheduler] add schedule name to MessageContext #50155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

[Scheduler] add schedule name to MessageContext #50155

merged 1 commit into from
Apr 26, 2023

Conversation

kbond
Copy link
Member

@kbond kbond commented Apr 25, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Alternative to #49864.

@carsonbot carsonbot added this to the 6.3 milestone Apr 25, 2023
@kbond
Copy link
Member Author

kbond commented Apr 25, 2023

/cc @tucksaun

@kbond kbond mentioned this pull request Apr 25, 2023
Closed
@kbond kbond force-pushed the scheduler-name-2 branch from 0414a55 to c2604b5 Compare April 25, 2023 22:44
tucksaun
tucksaun reviewed Apr 26, 2023
View reviewed changes
@kbond kbond force-pushed the scheduler-name-2 branch from c2604b5 to 278fb4e Compare April 26, 2023 14:16
@kbond kbond force-pushed the scheduler-name-2 branch from 278fb4e to dc0f0e2 Compare April 26, 2023 14:17
@kbond
Copy link
Member Author

kbond commented Apr 26, 2023

Based on feedback from @tucksaun, I've re-arranged the MessageGenerator::__construct() parameters slightly to require a name and make the checkpoint optional.

@fabpot
Copy link
Member

fabpot commented Apr 26, 2023

Thank you @kbond.

@fabpot fabpot mentioned this pull request Apr 26, 2023
Closed
@fabpot fabpot merged commit 32c5fb0 into symfony:6.3 Apr 26, 2023
OskarStark
OskarStark reviewed Apr 26, 2023
View reviewed changes
src/Symfony/Component/Scheduler/Generator/MessageGenerator.php
private readonly ClockInterface $clock = new Clock(),
CheckpointInterface $checkpoint = null,
Copy link
Contributor

@OskarStark OskarStark Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- CheckpointInterface $checkpoint = null,
+ ?CheckpointInterface $checkpoint = null,

@kbond kbond deleted the scheduler-name-2 branch April 26, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@tucksaun tucksaun tucksaun approved these changes

Assignees
No one assigned
Labels
Feature Scheduler Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@kbond @fabpot @tucksaun @OskarStark @carsonbot