Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpClient] Add PSR-18 to HttplugClient since HTTPlug is deprecated #50163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Relates to php-http/httplug#171

@carsonbot carsonbot added this to the 6.3 milestone Apr 26, 2023
@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 26, 2023
@derrabus
Copy link
Member

Does this change do anything? We should already implement through Http\Client\HttpClient.

@nicolas-grekas
Copy link
Member Author

You should be right, but I still prefer adding this code now since it's going to stay in v7

@derrabus
Copy link
Member

So the plan is to not implement the HTTPlug interface anymore in v7? Does the name HttplugClient still make sense then or should we rather add a PsrClient as a replacement?

@stof
Copy link
Member

stof commented Apr 26, 2023

@derrabus not the sync interface, as it is deprecated in favor of the PSR-18 one (the sync Httplug interface is already an empty one extending the PSR-18 one). the client will still implement the async interface (and the PSR-18 one).

@stof
Copy link
Member

stof commented Apr 26, 2023

and we already have a Psr18Client that implements only the PSR interfaces

@derrabus
Copy link
Member

Ah, got it, thanks.

@fabpot
Copy link
Member

fabpot commented Apr 26, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 8b6edd9 into symfony:6.3 Apr 26, 2023
@nicolas-grekas nicolas-grekas deleted the hc-plug branch April 27, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HttpClient ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants