[HttpKernel] Forward _stateless attribute to inline rendered fragments
#50198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a2d195 to
38db617
Compare
maxhelias
approved these changes
May 2, 2023
|
could you add a test covering this behavior to prevent regressions ? |
61389e3 to
725c105
Compare
|
@stof done. I simplified the code as well. |
nicolas-grekas
approved these changes
May 2, 2023
stof
approved these changes
May 2, 2023
725c105 to
fae3825
Compare
|
Thank you @MatTheCat. |
fabpot
added a commit
that referenced
this pull request
May 5, 2023
This PR was merged into the 6.3 branch. Discussion ---------- Profiler respect stateless attribute | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #50037 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Now that #50198 forward `_stateless` attribute in fragments, this PR check this attribute and make profiler stateless when is required. I don't know which tests I have to add because session is not checked. (I checked on reproducer and it's ok) Commits ------- 7820776 [WebProfilerBundle] Profiler respect stateless attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now inline rendered fragments have no mean of checking if the
_statelessattribute has been set so they cannot adapt accordingly. This PR would allow them not to use the session if$request->attributes->getBoolean('_stateless')is true.This could be used in
ProfilerController’ssearchBarActioneg.