[AssetMapper] Fix import map package parsing with an @ namespace #50206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @weaverryan. |
stof
reviewed
May 2, 2023
| @@ -111,8 +111,8 @@ public function update(): array | |||
| */ | |||
| public static function parsePackageName(string $packageName): ?array | |||
| { | |||
| // https://regex101.com/r/58bl9L/1 | |||
| $regex = '/(?:(?P<registry>[^:\n]+):)?(?P<package>[^@\n]+)(?:@(?P<version>[^\s\n]+))?/'; | |||
| // https://regex101.com/r/d99BEc/1 | |||
There was a problem hiding this comment.
I would remove this comment entirely. Someone wanting to get the regex explanation on regex101.com can copy-paste the regex instead.
There was a problem hiding this comment.
I got this idea from @dunglas - the nice thing about it is that the regex includes a bunch of examples. So if there is a problem in the future, you can quickly open this to see what the passing test cases are and then either validate that (A) the situation you are having trouble with SHOULD be working or (B) that your test case was never included.
There was a problem hiding this comment.
Exactly, the main benefit it that we can add tests for the regex.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used with the
importmap:requirecommand - e.g.It parses the string into the package name and potential version (and something called a "registry" which is specific to jspm). The original regex didn't account for namespaced packages.
Cheers!