[FrameworkBundle][Serializer] Add TranslatableNormalizer #50212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
4f15638 to
4b56a42
Compare
dunglas
requested changes
Jul 29, 2023
src/Symfony/Component/Serializer/Normalizer/TranslatableNormalizer.php
Outdated
Show resolved
Hide resolved
fc2526b to
c697ea5
Compare
dunglas
approved these changes
Aug 1, 2023
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Aug 1, 2023
|
Thank you @Jean-Beru. |
1dcaebe to
1ac8a2b
Compare
This was referenced Oct 21, 2023
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Oct 28, 2023
…lizer, add to changelog (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] throw better exception in TranslatableNormalizer, add to changelog | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | follows #50212 Commits ------- d8a03d1 throw better exception in TranslatableNormalizer, add to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5.2, Symfony introduced translatable objects. This PR adds a dedicated normalizer to translate them. It can be useful for an API to return translated properties.
Also I'm wondering if it could be considered as a BC break since translatable objects were handled by the ObjectNormalizer which currently returns a plain object.