Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge] skip subscriber if listener already defined #50224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2023
Merged

[DoctrineBridge] skip subscriber if listener already defined #50224

merged 1 commit into from
May 5, 2023

Conversation

alli83
Copy link
Contributor

@alli83 alli83 commented May 3, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations?
Tickets
License MIT
Doc PR

Following #49918 and doctrine/DoctrineBundle#1650 skip doctrine event subscriber if a doctrine event listener is already defined for the same definition.

@carsonbot carsonbot added this to the 6.3 milestone May 3, 2023
@alli83 alli83 force-pushed the doctrine-bridge-skip-subscriber-if-listener-defined branch from 27b50c9 to 4da5640 Compare May 3, 2023 08:01
@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label May 3, 2023
@nicolas-grekas nicolas-grekas force-pushed the doctrine-bridge-skip-subscriber-if-listener-defined branch from 4da5640 to 3d4ca5f Compare May 3, 2023 12:03
@nicolas-grekas nicolas-grekas force-pushed the doctrine-bridge-skip-subscriber-if-listener-defined branch from 3d4ca5f to 5a867c5 Compare May 3, 2023 12:09
nicolas-grekas
nicolas-grekas approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is important to allow moving out of subscribers by using #[AsDoctrineListener] on a class that implements Doctrine's EventSubscriberInterface.

@fabpot
Copy link
Member

fabpot commented May 5, 2023

Thank you @alli83.

@fabpot fabpot merged commit 218dfaa into symfony:6.3 May 5, 2023
@fabpot fabpot mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DoctrineBridge ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@alli83 @fabpot @nicolas-grekas @carsonbot