[AssetMapper] Fixing 2 bugs related to the compile command and importmaps #50231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 5, 2023
|
@weaverryan Can you rebase this PR now that #50219 is merged? |
src/Symfony/Component/AssetMapper/ImportMap/ImportMapManager.php
Outdated
Show resolved
Hide resolved
|
(rebase needed) |
bd3c42d to
329b413
Compare
|
Good to go now - thanks for the merges! |
329b413 to
f9f7274
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 bugs:
A) Running
assetmap:compilegives you apublic/assets/importmap.jsonfor fast importmap dumping on production. But, runningassetmap:compileagain later would re-use theimportmap.jsoninfo to create the newimportmap.json... meaning it would never update after the first compile.B) The importmap process generates 2 pieces of information: (A) the importmap and (B) which files from the importmap should be preloaded. When we use
assetmap:compile, we need to dump both pieces of info. So, we now also dump animportmap.preload.jsonfile. These are TWO files (and not just one) because we avoid parsingimportmap.jsonat runtime: we read the file and dump it straight out. We DO need to parse the "preload" file. So, I've kept them separate.Blocked by #50219, which has some changes that will fix the tests here.
Cheers!