[Serializer] Fix discriminator map not working with AbstractNormalizer::OBJECT_TO_POPULATE
#50480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er::OBJECT_TO_POPULATE`
|
👍 Thanks @HypeMC |
soyuka
approved these changes
May 31, 2023
|
Thank you @HypeMC. |
|
@nicolas-grekas It just occurred to me that this problem exists on v5.4 as well, should I open a new PR and target that branch? |
|
yes please |
nicolas-grekas
added a commit
that referenced
this pull request
May 31, 2023
…actNormalizer::OBJECT_TO_POPULATE` (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Followup / backport of #50480 since it should've originally targeted 5.4. The test is the same as in the previous PR, when merging upstream the changes in `instantiateObject()` should be discarded. Commits ------- ce08608 [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the mapped class is taken from
AbstractNormalizer::OBJECT_TO_POPULATEif it's set.