[HttpFoundation] add @throws to getPayload #50492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 31, 2023
|
Thank you @wiseguy1394. |
ro0NL
reviewed
May 31, 2023
| @@ -1508,6 +1508,8 @@ public function getContent(bool $asResource = false) | |||
|
|
|||
| /** | |||
| * Gets the decoded form or json request body. | |||
| * | |||
| * @throws JsonException When the body cannot be decoded to an array | |||
There was a problem hiding this comment.
should be RequestExceptionInterface IMHO
There was a problem hiding this comment.
Why not exact JsonException?
There was a problem hiding this comment.
@wiseguy1394 catching the general case seems more future proof
but no strong opionion, i dont believe in @throws bookkeeping anyway :)
|
Behavior changed in #50730 for empty contents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50490