[DependencyInjection] Fix casting scalar env vars from null #50517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
May 31, 2023
6277c6d to
dafa2c4
Compare
dafa2c4 to
4212e43
Compare
nicolas-grekas
approved these changes
Jun 1, 2023
4212e43 to
c4b16e5
Compare
|
Thank you @fancyweb. |
This was referenced Jun 26, 2023
Merged
Merged
Merged
|
is this a not a BC break, or introducion of a regression? previously a env var with a default of null: parameters:
env(SOME_VAR): ~6.3.0: 6.3.1: |
|
@bendavies Can you open a new issue please with a reproducer and I'll look at it, thanks. |
This was referenced Jun 29, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Jul 3, 2023
…mpty string (fancyweb) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix autocasting null env values to empty string | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | - | Deprecations? | - | Tickets | #50815 (comment) | License | MIT | Doc PR | - This PR fixes autocasting `null` env values to `''`. We continue to autocast all other values to string when there's no prefix. It doesn't revert #50517, it just fixes an unintended side effect. It doesn't fix #50815 request, it confirms the behavior: the solution for this issue would be to remove the `string:` prefix. There's still no solution to have the "keep null as null" and "cast if not null" behavior. Commits ------- 2c0815d [DependencyInjection] Fix autocasting null env values to empty string
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
Jul 3, 2023
…mpty string (fancyweb) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix autocasting null env values to empty string | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | - | Deprecations? | - | Tickets | symfony/symfony#50815 (comment) | License | MIT | Doc PR | - This PR fixes autocasting `null` env values to `''`. We continue to autocast all other values to string when there's no prefix. It doesn't revert symfony/symfony#50517, it just fixes an unintended side effect. It doesn't fix symfony/symfony#50815 request, it confirms the behavior: the solution for this issue would be to remove the `string:` prefix. There's still no solution to have the "keep null as null" and "cast if not null" behavior. Commits ------- 2c0815d04e [DependencyInjection] Fix autocasting null env values to empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a casting env var processor on
nullreturnsnull(it doesn't cast) which is not what one could expect and not what is documented. We could allow it.