[DependencyInjection] Fix support for false boolean env vars
#50530
Conversation
|
environment variables are always strings though. What you are covering in tests is not something compatible with actual environment variables (or with the DotEnv component). |
|
Because you can set any scalar value from PHP code, and they won't be converted to strings nor anything will prevent you to set them in the first place. FWIW, we've never had any troubles so far, be it with Symfony or DotEnv component. I'm covering with tests because it was a supported behaviour that has been broken with 6.3 release. If you think it shouldn't have been supported from the start, and thus that this is not a bug, I'm also fine with that, feel free to let me know and close this PR. |
|
It was not a supported behavior. It was an undefined behavior that happened to work. |
|
Thank you @okhoshi. |
After upgrading
symfony/dependency-injectionpackage to version 6.3, some of our env vars couldn't be found anymore.For some scripts, we are providing an adhoc default value to env vars by setting
$_SERVERdirectly. However, since version 6.3 of the DependencyInjection component, setting an env var tofalse(the boolean value, like in the snippet below) doesn't work anymore, and Symfony reports that the variable cannot be found.It seems to be a side effect of the changes made in #48705.