Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Show non-bundle extensions in debug:config & config:dump list view & completion #50548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2023
Merged

[FrameworkBundle] Show non-bundle extensions in debug:config & config:dump list view & completion #50548

merged 1 commit into from
Jun 8, 2023

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Jun 4, 2023 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Follow up to #50546 (should be merged first), adds non-bundle extensions to debug:config & config:dump list views:

class Kernel extends BaseKernel implements ExtensionInterface, ConfigurationInterface
{
    use MicroKernelTrait;

    protected function build(ContainerBuilder $container)
    {
        $container->registerExtension(new MyExtension());
    }

    public function getAlias()
    {
        return 'kernel';
    }

    // ...
}

image

@carsonbot carsonbot added this to the 6.4 milestone Jun 4, 2023
@HypeMC HypeMC mentioned this pull request Jun 4, 2023
Merged
chalasr
chalasr approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'd call that a bugfix

@HypeMC HypeMC force-pushed the kernel-extensions branch from bfe288e to 58ebfec Compare June 4, 2023 15:53
@HypeMC
Copy link
Contributor Author

HypeMC commented Jun 4, 2023

Good catch. I'd call that a bugfix

Works for me, if needed I'll rebase this with 5.4 once #50546 is merged.

nicolas-grekas added a commit that referenced this pull request Jun 8, 2023
@nicolas-grekas
bug #50546 [FrameworkBundle] Fix debug:config & config:dump in de…
dda4e7c 
…bug mode (HypeMC)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Fix `debug:config` & `config:dump` in debug mode

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #47623
| License       | MIT
| Doc PR        | -

Displaying configs for extensions without a bundle using the `debug:config` & `config:dump-reference` commands works depending on whether debug is `true` or `false`. The reason behind this is the following code:

https://github.com/symfony/symfony/blob/b4128fdefea4ff95b27861bf65ba789d24868df1/src/Symfony/Bundle/FrameworkBundle/Command/BuildDebugContainerTrait.php#L42-L60

When debug is `true` the extensions are never loaded in the container, so the commands don't work.

There are even tests for these cases but they are all executed with debug `false`.

This PR aims to make the commands work with both debug `true` & `false`. Another problem is that these extensions are not visible in the list of available extensions and are not offered by the completion feature, but since those seem more like new features I've created a separate PR for 6.4: #50548

Commits
-------

2824fc5 [FrameworkBundle] Fix `debug:config` & `config:dump` in debug mode
@HypeMC HypeMC force-pushed the kernel-extensions branch from 58ebfec to fbcdfab Compare June 8, 2023 19:32
@HypeMC HypeMC changed the base branch from 6.4 to 5.4 June 8, 2023 19:32
@HypeMC HypeMC force-pushed the kernel-extensions branch from fbcdfab to b31f700 Compare June 8, 2023 19:34
@nicolas-grekas
Copy link
Member

(rebase unlocked)

@HypeMC
Copy link
Contributor Author

HypeMC commented Jun 8, 2023

(rebase unlocked)

@nicolas-grekas Already done 😄

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 5.4 Jun 8, 2023
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit a267738 into symfony:5.4 Jun 8, 2023
@HypeMC HypeMC deleted the kernel-extensions branch June 8, 2023 21:33
This was referenced Jun 26, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @nicolas-grekas @chalasr @carsonbot